Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is-principal and typeof-principal, create-principal, and validate-principal shim #1160

Merged
merged 11 commits into from
Apr 26, 2023
Merged

Remove is-principal and typeof-principal, create-principal, and validate-principal shim #1160

merged 11 commits into from
Apr 26, 2023

Conversation

rsoeldner
Copy link
Member

No description provided.

@rsoeldner rsoeldner added the FV Formal verification label Mar 8, 2023
@rsoeldner rsoeldner changed the title Remove is-principal shim Remove is-principal and typeof-principal shim Mar 9, 2023
@rsoeldner rsoeldner requested a review from jwiegley March 9, 2023 07:51
@rsoeldner rsoeldner marked this pull request as ready for review March 9, 2023 07:51
@rsoeldner rsoeldner marked this pull request as draft March 13, 2023 08:44
@rsoeldner rsoeldner requested a review from jmcardon March 15, 2023 08:50
@rsoeldner rsoeldner marked this pull request as ready for review March 15, 2023 08:50
@rsoeldner rsoeldner changed the title Remove is-principal and typeof-principal shim Remove is-principal and typeof-principal, create-principal, and validate-principal shim Mar 15, 2023
@rsoeldner rsoeldner requested a review from emilypi March 21, 2023 07:29
emilypi
emilypi reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending comments

src-tool/Pact/Analyze/Eval/Core.hs Outdated Show resolved Hide resolved
src-tool/Pact/Analyze/Eval/Core.hs Outdated Show resolved Hide resolved
jwiegley
jwiegley reviewed Mar 23, 2023
View reviewed changes
docs/en/pact-properties-api.md Outdated Show resolved Hide resolved
docs/en/pact-properties-api.md Outdated Show resolved Hide resolved
src-tool/Pact/Analyze/Eval/Core.hs Outdated Show resolved Hide resolved
@rsoeldner rsoeldner mentioned this pull request Mar 24, 2023
Merged
@EnoF EnoF mentioned this pull request Mar 30, 2023
Closed
emilypi
emilypi approved these changes Apr 13, 2023
View reviewed changes
src-tool/Pact/Analyze/Eval/Term.hs Outdated Show resolved Hide resolved
imalsogreg
imalsogreg approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@imalsogreg imalsogreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the walk-through, I understand a lot better now.

@rsoeldner rsoeldner merged commit 10a95cf into master Apr 26, 2023
6 checks passed
@rsoeldner rsoeldner deleted the rsoeldner/is-principal branch April 26, 2023 07:06
jwiegley pushed a commit that referenced this pull request Apr 26, 2023
@rsoeldner @jwiegley
FV remove is-principal and typeof-principal, create-principal, …
ab8c927 
…and `validate-principal` shims (#1160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiegley jwiegley jwiegley approved these changes

@emilypi emilypi emilypi approved these changes

@imalsogreg imalsogreg imalsogreg approved these changes

@jmcardon jmcardon Awaiting requested review from jmcardon jmcardon is a code owner

@sirlensalot sirlensalot Awaiting requested review from sirlensalot

Assignees
No one assigned
Labels
FV Formal verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rsoeldner @jwiegley @imalsogreg @emilypi