-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup PactContinuationSpec #1222
Conversation
Thank you for taking the time to factor this out, @edmundnoble. Most of it looks entirely mechanical and straightforward, a clear improvement. I'll review the other bits tomorrow, if my review is still needed then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR increases clarity, thank you 👍
sysModuleCmd `succeedsWith` (`shouldBe` textVal "system module loaded") | ||
acctModuleCmd `succeedsWith` (`shouldBe` textVal "TableCreated") | ||
testModuleCmd `succeedsWith` (`shouldBe` textVal "test module loaded") | ||
succeeds createAcctCmd -- Alice should be funded with $100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the comment provide any value? (I've noticed the removal here too).
@@ -1330,23 +1327,25 @@ shouldMatch' CommandResultCheck{..} results = checkResult _crcExpect apiRes | |||
Nothing -> expectationFailure $ "Failed to find ApiResult for " ++ show _crcReqKey | |||
Just cr -> crTest cr | |||
|
|||
succeeds :: HasCallStack => Command Text -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This provides clarity 👍
This continues #1220's larger changes. From #1220:
failsWith Nothing
andsucceedsWith Nothing
have become fails and succeedsfailsWith (Just e)
andsucceedsWith (Just e)
have becomefailsWith (``shouldBe`` e)
andsucceedsWith (``shouldBe`` e)
Just
-wrapping utilities have been deletedPactError
etc.PR checklist:
cabal run tests
. If they pass locally, docs are generated.pact -t
), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: