Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoverageSpec to PactTests #1228

Merged
merged 1 commit into from
May 12, 2023
Merged

Add CoverageSpec to PactTests #1228

merged 1 commit into from
May 12, 2023

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented May 12, 2023

This PR adds CoverageSpec to the Pact test suite. It was not enabled during #1151, but passes locally, and via cabal run tests.

PR checklist:

  • (N/A) Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (N/A) Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • (N/A) Any changes that could be relevant to users have been recorded in the changelog
  • (N/A) In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • (N/A) Confirm replay/back compat
  • (N/A) Benchmark regressions
  • (N/A) (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

@emilypi emilypi requested a review from jwiegley as a code owner May 12, 2023 20:34
@emilypi emilypi merged commit 212ab9e into master May 12, 2023
12 checks passed
@emilypi emilypi deleted the mlep/add-coveragespec branch May 12, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants