Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace cryptonite by crypton #1240

Merged
merged 1 commit into from
Jul 11, 2023
Merged

replace cryptonite by crypton #1240

merged 1 commit into from
Jul 11, 2023

Conversation

larskuhtz
Copy link
Contributor

This is supposed to not change the actual code, because crypton is a copy of cryptonite.

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't require replay because this should be a code for code replica fork at this point.

@emilypi
Copy link
Member

emilypi commented Jul 10, 2023

@jwiegley Replay passes for the branch pact-crypton-migration on chainweb-node: https://github.com/kadena-io/chainweb-node/actions/runs/5467897926/jobs/9955358526. Can we get this in?

@emilypi emilypi merged commit 97b0f78 into master Jul 11, 2023
12 checks passed
@emilypi emilypi deleted the lars/crypton branch July 11, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants