Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump integer thresholds #1272

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Bump integer thresholds #1272

merged 2 commits into from
Aug 8, 2023

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented Aug 8, 2023

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

@jwiegley
Copy link
Contributor

jwiegley commented Aug 8, 2023

I would like just to see a golden test that confirms that the new threshold takes effect only after the given feature flag is enabled.

@jmcardon jmcardon merged commit b160c26 into master Aug 8, 2023
7 checks passed
@jmcardon jmcardon deleted the jose/bump-integers branch May 10, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants