Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modref infos in capability guards #1278

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Conversation

jmcardon
Copy link
Member

Same issue as #1273 unfortunately, just in cap guards.

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact


(defun insert-hash (k:string h:string)
(write hashes-table k {"h":h})
(concat ["added hash ", h, " to table"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we return the hash value, and expect them to match a hardcoded value in each case, as a cheap golden. We've gotten bitten with these values changing out from under us, so let's lock it down.

Suggested change
(concat ["added hash ", h, " to table"])
h

@jmcardon jmcardon merged commit 590ae43 into master Aug 16, 2023
7 checks passed
@jmcardon jmcardon deleted the jose-stuart/capguard-modref branch May 10, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants