Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fv str-to-int #1304

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix fv str-to-int #1304

merged 3 commits into from
Oct 3, 2023

Conversation

rsoeldner
Copy link
Member

This PR fixes the order of parameters (in case base is defined) to match documentation https://pact-language.readthedocs.io/en/latest/pact-properties-api.html?highlight=str-to-int#str-to-int.
Additionally, we re-organize str-to-int str and str-to-int base str to be close to each other.
I've added a property test case for both cases.

fixed #1303

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

Copy link
Contributor

@imalsogreg imalsogreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

@rsoeldner rsoeldner merged commit e72d867 into master Oct 3, 2023
13 checks passed
@rsoeldner rsoeldner deleted the rsoeldner/fix-fv-str2int branch October 3, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FV: str-to-int doesn't parse
4 participants