fix enforce-pact-version decimal parser #1334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enforce-pact-version
was actually using lexicographic comparison due to the fact that the digit-parser is a stringy parser:The problem:
Which leads to the following case for the first time in Pact's history, now that it has a double-digit version part:
馃帀
This PR uses integer parsing on the version segments:
PR checklist:
* [ ] Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issuecabal run tests
. If they pass locally, docs are generated.* [ ] Any changes that could be relevant to users have been recorded in the changelog* [ ] In case of changes to the Pact trace output (pact -t
), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: