Support Pact Events #819
Merged
Support Pact Events #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilypi
reviewed
Oct 1, 2020
| -- otherwise push, test, pop and install onto head | ||
| evalComposed = checkManaged i af cap cdef >>= \r -> case r of | ||
| Nothing -> push >> test >> popCapStack installComposed | ||
| Just composed -> installComposed (CapSlot scope cap composed) | ||
| Just composed -> emitCap >> installComposed (CapSlot scope cap composed) |
There was a problem hiding this comment.
Nice - we only emit on successful install, and install is a pure function.
| data PactSuccess = PactSuccess | ||
| { _successValue :: PactValue | ||
| , _successEvents :: [PactEvent] | ||
| } deriving (Eq, Show, Generic) |
| { _eventName :: QualifiedName | ||
| , _eventParams :: [PactValue] | ||
| , _eventModuleHash :: ModuleHash | ||
| } deriving (Eq, Show, Generic) |
There was a problem hiding this comment.
Yes, and I also broke into Text + ModuleName, mainly because of the Info in qualified name messing up the JSON, but also allows for indexing on name/topic alone (ie all TRANSFERs, not just coin.TRANSFER etc)
ronja-sigurdsdottir
approved these changes
Oct 2, 2020
emilypi
approved these changes
Oct 2, 2020
LindaOrtega
previously requested changes
Oct 2, 2020
Co-authored-by: Linda Ortega <LindaOrtega@users.noreply.github.com>
Co-authored-by: Linda Ortega <LindaOrtega@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #818