Emit synthetic cross-chain events #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2021 11:14
sirlensalot
requested review from
emilypi,
emmanueldenloye,
ggobugi27 and
mightybyte
| emitEventUnsafe (QualifiedName "pact" name def) params mhash | ||
|
|
||
| emitEventUnsafe :: QualifiedName -> [PactValue] -> ModuleHash -> Eval e () | ||
| emitEventUnsafe QualifiedName{..} params mh = do |
There was a problem hiding this comment.
Why not append here? Also, what about using a dlist?
EDIT: I meant to say cons instead of append.
There was a problem hiding this comment.
Events are rarely more than 1-2 long so not concerned about append performance as of yet ...
| return result | ||
|
|
||
| applyPact _ _ t _ = evalError' t "applyPact: invalid defpact body, expected list of steps" | ||
|
|
||
|
|
||
| -- | Synthesize events for cross chain. | ||
| emitXChainEvents :: Maybe Yield -> PactExec -> Eval e () | ||
| emitXChainEvents mResume PactExec {..} = do |
There was a problem hiding this comment.
Is it acceptable that mResume is Nothing while _peYield yields (pardon the obvious pun) a Just value?
There was a problem hiding this comment.
Yes, in fact that's expected. I'll update comments
emilypi
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit synthetic events for cross-chain
defpactexecutions. The signatures are(pact.X_YIELD targetChain continuationName continuationArgs)for cross-chain yields(pact.X_RESUME sourceChain continuationName continuationArgs)for cross-chain resumesThus a cross-chain transfer send from 0 to 1 would be
(pact.X_YIELD "1" "coin.transfer-crosschain" ["Bob" "Alice" 10.0])on 0 then(pact.X_RESUME "0" "coin.transfer-crosschain" ["Bob" "Alice" 10.0])on 1.