Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongodb dependency. Is it necessary? #96

Open
neoromantic opened this issue Feb 11, 2015 · 5 comments
Open

Mongodb dependency. Is it necessary? #96

neoromantic opened this issue Feb 11, 2015 · 5 comments

Comments

@neoromantic
Copy link

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on low-resources ARM architecture) and it would be great to make fast-render more versatile.

@arunoda
Copy link
Contributor

arunoda commented Feb 11, 2015

Fast render using accounts-base to authenticate users in the fast render
scope. So, it's something we needed.
On 2015 පෙබ 11, බදාදා at ප.ව. 6.39 Sergey Petrov notifications@github.com
wrote:

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on
low-resources ARM architecture) and it would be great to make fast-render
more versatile.


Reply to this email directly or view it on GitHub
#96.

@neoromantic
Copy link
Author

I see that, but it has already checks for Meteor.users collection availability and Accounts package availability right in its code. In case (like mine) when meteor accounts system is not used, fast-render could just ignore this context (i.e. run publication functions without userId in context). 

Basically, I’ve just forked fast-render into my local package, removed accounts-base dependency and it’s all working. 

Why not move it to weak dependencies?

On Feb 11, 2015, at 4:41 PM, Arunoda Susiripala notifications@github.com wrote:

Fast render using accounts-base to authenticate users in the fast render
scope. So, it's something we needed.
On 2015 පෙබ 11, බදාදා at ප.ව. 6.39 Sergey Petrov notifications@github.com
wrote:

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on
low-resources ARM architecture) and it would be great to make fast-render
more versatile.


Reply to this email directly or view it on GitHub
#96.


Reply to this email directly or view it on GitHub
.

@arunoda
Copy link
Contributor

arunoda commented Feb 11, 2015

Weak dependency idea is a goo thing. If you can work ok a PR, I am happy to
accept.
On 2015 පෙබ 11, බදාදා at ප.ව. 7.52 Sergey Petrov notifications@github.com
wrote:

I see that, but it has already checks for Meteor.users collection
availability and Accounts package availability right in its code. In case
(like mine) when meteor accounts system is not used, fast-render could just
ignore this context (i.e. run publication functions without userId in
context).

Basically, I’ve just forked fast-render into my local package, removed
accounts-base dependency and it’s all working.

Why not move it to weak dependencies?

On Feb 11, 2015, at 4:41 PM, Arunoda Susiripala <
notifications@github.com> wrote:

Fast render using accounts-base to authenticate users in the fast render
scope. So, it's something we needed.
On 2015 පෙබ 11, බදාදා at ප.ව. 6.39 Sergey Petrov <
notifications@github.com>
wrote:

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on
low-resources ARM architecture) and it would be great to make
fast-render
more versatile.


Reply to this email directly or view it on GitHub
#96.


Reply to this email directly or view it on GitHub
.


Reply to this email directly or view it on GitHub
#96 (comment)
.

@neoromantic
Copy link
Author

Great, will do soon. Thanks.

On Feb 11, 2015, at 5:25 PM, Arunoda Susiripala notifications@github.com wrote:

Weak dependency idea is a goo thing. If you can work ok a PR, I am happy to
accept.
On 2015 පෙබ 11, බදාදා at ප.ව. 7.52 Sergey Petrov notifications@github.com
wrote:

I see that, but it has already checks for Meteor.users collection
availability and Accounts package availability right in its code. In case
(like mine) when meteor accounts system is not used, fast-render could just
ignore this context (i.e. run publication functions without userId in
context).

Basically, I’ve just forked fast-render into my local package, removed
accounts-base dependency and it’s all working.

Why not move it to weak dependencies?

On Feb 11, 2015, at 4:41 PM, Arunoda Susiripala <
notifications@github.com> wrote:

Fast render using accounts-base to authenticate users in the fast render
scope. So, it's something we needed.
On 2015 පෙබ 11, බදාදා at ප.ව. 6.39 Sergey Petrov <
notifications@github.com>
wrote:

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on
low-resources ARM architecture) and it would be great to make
fast-render
more versatile.


Reply to this email directly or view it on GitHub
#96.


Reply to this email directly or view it on GitHub
.


Reply to this email directly or view it on GitHub
#96 (comment)
.


Reply to this email directly or view it on GitHub
.

@julian-rare
Copy link

Any news on this? I'm working on a mongoless meteor app with ssr, but found mongo to be a major pain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants