-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mkdocs documentation #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'm getting this error though:
(eva-3.10) ➜ eva (77-add-mkdocs-documentation) mkdocs serve ✭ ✱
INFO - Building documentation...
INFO - Cleaning site directory
INFO - The following pages exist in the docs directory, but are not included in the "nav" configuration:
- reference.md
ERROR - mkdocstrings: src.eva.vision.data.datasets.vision could not be found
ERROR - Error reading page 'reference/vision.md':
ERROR - Could not collect 'src.eva.vision.data.datasets.vision'
the |
@roman807 Now it works! This looks good. I briefly compared it with the fastAPI docs and noted the following:
|
@nkaenzig re your 3 comments from above: (1) added the parameter tables, they are not identical to fastAPI's example, but more comprehensive (columns: name, type, description, default) (2) yes, we will have to add such examples to the docstrings (3) i see they have expandable source code boxes as well, e.g.: https://fastapi.tiangolo.com/reference/parameters/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We can start iterating an build from this commit, as I'm not as well are super fluent of mkdocs
when we address @nkaenzig points, lets merge it!
@roman807 Regarding 1), the last thing I'm noticing is that in our docs, the parameters table appears in the end (after listing all the properties & methods). Is it possible to move this to the beginning like this? |
@nkaenzig the table appears immediately after the method (e.g. the parameters to the method What FastAPI does is annotating those arguments with |
@roman807 Got it, yes seems that I was confusing the init with public methods. Displaying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #77
Adds basic mkdocs documentation, following the example of FastAPI (see: documentation, repo)
To review, run
and check