Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐧 Separate rpi3 from rpi4 #1705

Merged
merged 8 commits into from
Aug 10, 2023
Merged

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Aug 10, 2023

What this PR does / why we need it:
Separates building of rpi into rpi3 and 4 models. Changes the default model from rpi64 to rpi4. Also passes the model into more places as we had it fixed in some of the targets

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1636

Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka requested a review from a team August 10, 2023 06:52
Itxaka and others added 2 commits August 10, 2023 08:53
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka@kairos.io>
mauromorales
mauromorales previously approved these changes Aug 10, 2023
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka merged commit 4a19be8 into kairos-io:master Aug 10, 2023
5 of 7 checks passed
@Itxaka Itxaka deleted the rpi3_rpi4_separation branch August 10, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Produce 2 different images for rpi 3 and 4
2 participants