Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osv scanning for PRs #2678

Merged
merged 18 commits into from
Jul 1, 2024
Merged

Add osv scanning for PRs #2678

merged 18 commits into from
Jul 1, 2024

Conversation

mauromorales
Copy link
Member

@mauromorales mauromorales commented Jun 28, 2024

relates to #2647 and #2670

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

addresses https://osv.dev/GHSA-gcq9-qqwx-rgj3

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
addresses https://osv.dev/GHSA-ppxx-5m9h-6vxf

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@mauromorales mauromorales changed the title [WIP] Add osv scanning for PRs Add osv scanning for PRs Jul 1, 2024
@mauromorales mauromorales self-assigned this Jul 1, 2024
@mauromorales mauromorales marked this pull request as ready for review July 1, 2024 12:08
@mauromorales mauromorales requested a review from a team July 1, 2024 12:08
@Itxaka
Copy link
Member

Itxaka commented Jul 1, 2024

saw this on the ovs

Skipping call analysis on Go code since Go is not installed.

Is this correct?

@mauromorales
Copy link
Member Author

saw this on the ovs

Skipping call analysis on Go code since Go is not installed.

Is this correct?

Good question, my guess is that it doesn't see anything but the go.mod and go.sum files so not the tests dir with the go code there. But do we want to test the tests dir? Since it's not shipped to the user

@mauromorales
Copy link
Member Author

I think it's ok because by default it runs recursively

@mauromorales mauromorales merged commit 8c48d3d into master Jul 1, 2024
43 checks passed
@mauromorales mauromorales deleted the add-osv branch July 1, 2024 14:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants