Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fips-static version of kairos packages #324

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Add fips-static version of kairos packages #324

merged 2 commits into from
Jul 6, 2023

Conversation

mudler
Copy link
Member

@mudler mudler commented Jul 5, 2023

So we can use them in all the flavors

@mudler
Copy link
Member Author

mudler commented Jul 5, 2023

This is an attempt to have generic framework fips images instead of per-flavor.

Related to: kairos-io/kairos#362

@mudler mudler requested a review from a team July 5, 2023 10:22
So we can use them in all the flavors

Signed-off-by: mudler <mudler@kairos.io>
@mudler
Copy link
Member Author

mudler commented Jul 6, 2023

mmm locally builds fine:

 INFO   # command-line-arguments
       /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/12/../../../x86_64-linux-gnu/libcrypto.a(libcrypto-lib-dso_dlfcn.o): in function `dlfcn_globallookup':
       (.text+0x11): warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
       /usr/bin/ld: /tmp/go-link-3916787737/000003.o: in function `mygetgrouplist':
       /_/os/user/getgrouplist_unix.go:15: warning: Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
       /usr/bin/ld: /tmp/go-link-3916787737/000002.o: in function `mygetgrgid_r':
       /_/os/user/cgo_lookup_unix.go:37: warning: Using 'getgrgid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
       /usr/bin/ld: /tmp/go-link-3916787737/000002.o: in function `mygetgrnam_r':
       /_/os/user/cgo_lookup_unix.go:42: warning: Using 'getgrnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
       /usr/bin/ld: /tmp/go-link-3916787737/000002.o: in function `mygetpwnam_r':
       /_/os/user/cgo_lookup_unix.go:32: warning: Using 'getpwnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
       /usr/bin/ld: /tmp/go-link-3916787737/000002.o: in function `mygetpwuid_r':
       /_/os/user/cgo_lookup_unix.go:27: warning: Using 'getpwuid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
       /usr/bin/ld: /tmp/go-link-3916787737/000008.o: in function `_cgo_2ac87069779a_C2func_getaddrinfo':
       /tmp/go-build/cgo_unix.cgo2.c:58: warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
       /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/12/../../../x86_64-linux-gnu/libcrypto.a(libcrypto-lib-bio_sock.o): in function `BIO_gethostbyname':
       (.text+0x81): warning: Using 'gethostbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
       
 INFO   Removing intermediate container 422142b6d46e
        ---> 6288f346fb51
       Step 14/14 : RUN chmod +x /system/discovery/kcrypt-discovery-challenger
 INFO    ---> Running in 7ebe36deffdb
 INFO   Removing intermediate container 7ebe36deffdb
        ---> 8db0241fe030
       Successfully built 8db0241fe030
 INFO   Successfully tagged luet/cache:afafa54fea81203cb7fa00e407ae284d026b1c1b7166cf9f3bf68b72dac69741
 INFO   SUCCESS 🐋  Building image luet/cache:afafa54fea81203cb7fa00e407ae284d026b1c1b7166cf9f3bf68b72dac69741 done
 INFO   📦  fips-static/kcrypt-challenger-0.5.0 🔨  Generating delta

Signed-off-by: mudler <mudler@kairos.io>
@mudler
Copy link
Member Author

mudler commented Jul 6, 2023

PEBCAK. I forgot to commit the fix - was working locally but not remotely 🤦

@mudler mudler requested a review from a team July 6, 2023 09:27
@mudler
Copy link
Member Author

mudler commented Jul 6, 2023

yesterday while trying to fix the error I've added 2498af3 locally but forgot to commit it. from that point I forgot to have it there and assumed wasn't solving the issue.. instead it was the needed fix 😅

Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mudler mudler merged commit f9ea911 into main Jul 6, 2023
3 checks passed
@mudler mudler deleted the dev/fips_generic branch July 6, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants