Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in metrics tags #27

Closed
robshep opened this issue Nov 21, 2014 · 0 comments
Closed

Bug in metrics tags #27

robshep opened this issue Nov 21, 2014 · 0 comments

Comments

@robshep
Copy link
Contributor

robshep commented Nov 21, 2014

Bug in Metrics#addTags(Map tags) - line 76

https://github.com/kairosdb/kairosdb-client/blob/master/src/main/java/org/kairosdb/client/builder/Metric.java#L76

The setter doesn't reference the instance field, this.tags, so it doesn't modify the field.

fixed in my fork, Pull request to follow
robshep added a commit to robshep/kairosdb-client that referenced this issue Nov 21, 2014
@robshep
fix for addTags(Map) bug kairosdb#27
e498e40
@FrEaKmAn FrEaKmAn mentioned this issue Feb 26, 2015
Closed
jsabin added a commit that referenced this issue May 14, 2015
@jsabin
Merge pull request #28 from robshep/master
40a7e7c 
fix for addTags(Map) bug #27
@jsabin jsabin closed this as completed May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsabin @robshep