Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

method addTags will not add tags because "this" keyword is missing. #33

Closed
chiragarora17 opened this issue Feb 26, 2015 · 2 comments
Closed

method addTags will not add tags because "this" keyword is missing. #33

chiragarora17 opened this issue Feb 26, 2015 · 2 comments

Comments

@chiragarora17
Copy link

https://github.com/kairosdb/kairosdb-client/blob/master/src/main/java/org/kairosdb/client/builder/Metric.java

In Metric.java, I tried using addTags but for some reason, it wasn't adding the tags. When I debugged it, I found that you were using same name variable "tags" locally and globally and therefore, tags from map wasn't added into the global variable. Please use this.tags on line 76
@FrEaKmAn
Copy link
Contributor

Yes, there is already a bug #27 and pull fix #28

@brianhks @jsabin can someone please update the client because there are few bug fixes waiting...

@jsabin
Copy link
Contributor

jsabin commented May 14, 2015

Fixed.

@jsabin jsabin closed this as completed May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FrEaKmAn @jsabin @chiragarora17