Partial implementation of Rust output #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ber variables would get redeclared with a new type if it was a vector
…neric types on Box
attribute readers
Rust match statements do not work with vector comparison, thus if statements must be used instead.
GreyCat
reviewed
Aug 10, 2018
| @@ -116,7 +116,8 @@ abstract class LanguageCompiler( | |||
| def seek(io: String, pos: Ast.expr): Unit | |||
| def popPos(io: String): Unit | |||
| def alignToByte(io: String): Unit | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This one adds trailing whitespaces.
|
Merging this in as well. Thanks you very much for all this hard work! It's very impressive! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an (as yet incomplete) implementation of Rust output, as discussed in issue kaitai-io/kaitai_struct#22.