Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android DTO partition is missing AVB signature #449

Open
armijnhemel opened this issue Mar 14, 2021 · 1 comment
Open

Android DTO partition is missing AVB signature #449

armijnhemel opened this issue Mar 14, 2021 · 1 comment

Comments

@armijnhemel
Copy link
Collaborator

Nitpicking, when looking at the diagram here:

https://source.android.com/devices/architecture/dto/partitions

it seems that the DTO partition should also include the AVB signature. Currently this is not the case. The current .ksy describes the dtbo.img file but that is only part of a DTO partition. I can see two solutions:

  1. add AVB signature to the .ksy
  2. rename the .ksy to indicate it only describes the dtbo.img file
@generalmimon
Copy link
Member

generalmimon commented Mar 14, 2021

Good catch! The android_dto spec was merged just a few days ago from a pull request by @evdenis (#415), so I hope he might have an idea how to handle this.

However, the test files provided by @evdenis in #415 (comment) apparently do not have any AVB signature at the end of file either - the files are parsed to the end (and not with size-eos: true).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants