Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android's DTB/DTBO partitions format #415

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Conversation

evdenis
Copy link
Contributor

@evdenis evdenis commented Feb 9, 2021

Copy link
Member

@generalmimon generalmimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments I wrote below, I would consider appropriate to add some short descriptions and notes to the individual fields whose meaning might be unclear - what is page_size, version, id, rev or custom?

archive/dto.ksy Outdated Show resolved Hide resolved
archive/dto.ksy Outdated Show resolved Hide resolved
archive/dto.ksy Outdated Show resolved Hide resolved
archive/dto.ksy Outdated Show resolved Hide resolved
archive/dto.ksy Outdated Show resolved Hide resolved
archive/dto.ksy Outdated Show resolved Hide resolved
archive/dto.ksy Outdated Show resolved Hide resolved
archive/dto.ksy Outdated Show resolved Hide resolved
archive/dto.ksy Outdated Show resolved Hide resolved
archive/dto.ksy Outdated Show resolved Hide resolved
@evdenis
Copy link
Contributor Author

evdenis commented Feb 10, 2021

Copy link
Member

@generalmimon generalmimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants