DS_Store - Fix block size computation #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing parentheses cause wrong computation of block sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Missing parentheses in the
.DS_Storefile description cause wrong computation of block sizes.I was quite surprised to find this bug, as everything worked well when I submitted the file description to the format gallery years ago. I tried to reproduce the setup I used at that time (Kaitai Struct compiler and runtime in version 0.8, etc.), but in vain. Just like if the bug has always been there. Anyway, this PR fixes the issue.
You can find sample files for testing in my original PR (#131).
Thanks.