-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.DS_Store parsing #30
Comments
Original issue reported on code.google.com by
|
Original issue reported on code.google.com by |
Original issue reported on code.google.com by |
Original issue reported on code.google.com by |
Original issue reported on code.google.com by |
Original issue reported on code.google.com by |
Original issue reported on code.google.com by |
Original issue reported on code.google.com by |
Added/updated help add-ons
I started to look into this based on the kaitai library and model. My first attempt wasn't successful, thinking maybe I just had a particularly fickle example file I ran it through an online parser which had no problem with it. (I did get the pieces setup, adjusted the spider filter, etc. so the ground work is there 👍). Bringing in the kaitai library(ies) just for this might be overkill, I may look at just strings'ing it as originally suggested (something like http://www.java2s.com/Code/Java/Data-Type/Stringsextractprintablestringsfrombinaryfile.htm) or reimplementing one of the Open Source python etc based parsers in Java? |
This can be implemented as an add-on, the libraries would not be a big problem IMO. Have you checked their size? |
I had started with it in core, but I can look at re-doing things as an add-on. I wasn't as much concerned about the size of the libraries as their usefulness, since they didn't work as advertised 'out of the box' I figured it might be more simple to build something from scratch vs. trying to debug and revise whatever was broken with kaitai. |
If that's faster/easier, sounds good. |
Hi, I am the author of the I've actually been thinking about writing a ZAP extension for this very purpose for a while now but I didn't realise that there was already a thread about it. |
@SkypLabs Thanks for reaching out, I had been looking into using that model but encountered a few build issues. I'll revive the branch and add some notes/questions here. |
@SkypLabs in the generated format, line 662:
Specifically on the blockId part. I think I had previously worked around this but I had to re-implement things this morning (I guess I'd done away with the previous feature branch.) |
Hey @kingthorin, sorry for my late answer. I just compiled the
|
@SkypLabs thank you! |
@SkypLabs any idea how to get some attention/movement on that? 😉 |
I wish, but it seems the ticket finally got some traction from project members! 🤞 |
@SkypLabs it seems that the katai team has provided a fix/work around. I know you said earlier that the existing java class page provides instructions but it's still really unclear to me. If there was a working PoC of some sort I feel I'd be much better positioned to sort it out. (Getting the structure is clear'ish, I think I can turn an HTTP response into a byte array to be loaded, but interacting with it in useful ways isn't: I don't want to manipulate the file I just want to extract paths/filenames and use them.) |
Hey @kingthorin. Sorry again for the late answer. Yes I've seen their suggestion. I'll submit a PR to update my |
PR created: kaitai-io/kaitai_struct_formats#632 |
Wonderful, thanks very much! |
FYI, the PR has been merged. |
@SkypLabs sorry to be a pain, but any news on this?
Thanks in advance! |
Hi @kingthorin, Sorry, I hadn't forgotten but I had difficulties finding the time to work on it. Furthermore, I hit a nasty bug when I tried to use the compiled KSY file. I submitted a patch to fix it: kaitai-io/kaitai_struct_formats#637. I've started to write small code examples in both Python and Java. You can them here. I will try to finish them in the next coming days. |
Thanks for sticking with it. I appreciate all your help!! |
I'm as eager as you to see this feature land! I just struggle with time. My fix has been merged: kaitai-io/kaitai_struct_formats#637 For your information, you can use Kaitai Struct's online IDE to interactively parse a If you want to try it out yourself, you can find sample files in my original PR. And don't forget to manually apply my fix as the |
Cool, thanks |
Hi @kingthorin, The Python implementation is complete: https://gist.github.com/SkypLabs/bc5510838acf7d6a7e3562999091f4c0#file-parser-py I am now implementing the same logic in Java. |
Cool, thanks! |
There you go: https://gist.github.com/SkypLabs/bc5510838acf7d6a7e3562999091f4c0#file-app-java It's a quick-and-dirty first implementation but it does the job. |
That's wonderful! I just skimmed it quickly and it seems to hit all the high points, so hopefully from there I can implement or implement and tweak any edge cases. Thank you very much! |
Great! Keep me posted. I'd like to participate in the add-on creation. |
It probably won't be an add-on itself, I plan to just add it as a new component to the spider. But I'll definitely let you know when I have something together (hopefully in the next week or so). It'll probably be somewhat like the SvgHrefParser and add a seed similar to the robots.txt and sitemap.xml handling (Might also need to add it to the options/params, I'll have to discuss that with the team.) Edit: Actually it'll be a different seed handling than robots and sitemap since they're root and this is more "everywhere". https://github.com/zaproxy/zap-extensions/blob/534f8a8da38d364e43cbd5c921d212feda117836/addOns/spider/src/main/java/org/zaproxy/addon/spider/Spider.java#L298-L313 |
I’ve got the functional bits well underway: https://github.com/kingthorin/zap-extensions/tree/ds-store Just need to tackle the the user interface bits: options dialog/params, api support. |
That looks promising! I look forward to testing it once ready. By the way, I meant to write a blog post about this new feature, to explain what a |
Definitely! |
Released and announced: https://twitter.com/zaproxy/status/1628803269362429959 |
That's awesome! 🥳 I'll try to have the blog post ready shortly. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Original issue reported on code.google.com by
fitblip
on 2010-12-17 21:32:15The text was updated successfully, but these errors were encountered: