Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow channel string in rgba() #57

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Conversation

emielbeinema
Copy link
Contributor

This PR aims to add support for channel strings, fixing for example test

<===> no_alpha/var/arg_1/input.scss
a {b: rgba(var(--foo) 2 3)}

<===> no_alpha/var/arg_1/output.css
a {
  b: rgba(var(--foo), 2, 3);
}

<===>

These changes decrease the number of failing tests with 18.

@AxelMontini
Copy link

hmmm it only needs to be cargo fmt'd, can be fixed quickly

@kaj
Copy link
Owner

kaj commented Dec 16, 2019

Seems reasonable and fixes some checks.

Thank you for the contribution!

@kaj kaj merged commit 96da978 into kaj:master Dec 16, 2019
kaj added a commit that referenced this pull request Dec 16, 2019
kaj added a commit that referenced this pull request Dec 25, 2019
* Issue #54: Add a LICENSE file.
* PR #57: Allow channel string in rgba()
* Issue #58: Let ructe::Error implement std::error::Error.
* Issue #59: Improve `@import` and media rules.
* Implement `@error` and `@warn` directives.
* Improve string unquoting, including multi-position numerical
  escapes.
* Improve at-rule parsing.
* Fix strange operator handling.
* Implement modulo operator.
* Fix line breaks in comments.
* Handle bad argument to `random()` function.
* Update test suite to e9e219bdf (2019-12-19).
* Some refactorig and clean-up.

Thanks to @emielbeinema, @maxbrunsfeld, and @Boiethios for contributed
code and suggestios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants