Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a license file #54

Closed
maxbrunsfeld opened this issue Aug 19, 2019 · 2 comments
Closed

Include a license file #54

maxbrunsfeld opened this issue Aug 19, 2019 · 2 comments

Comments

@maxbrunsfeld
Copy link

The package's Cargo.toml specifies a License of MIT/Apache-2.0. But I think that conceptually, "MIT" and "Apache-2.0" are only templates for licenses, and the standard practice is to include in the repository (and in the published crate) a file called LICENSE containing your actual license (usually just the MIT/Apache template, with your name and the year filled in).

When you get a chance, would you be up for adding a LICENSE file to your repo, to eliminate any legal issues with using this library?
@maxbrunsfeld
Copy link
Author

@kaj Was the the omission of a license here intentional?

@kaj
Copy link
Owner

kaj commented Aug 29, 2019

Not more than that I thought the extra files would be redundant. The cargo manual says:

If a package is using a nonstandard license, then this key may be specified in lieu of the above key and must point to a file relative to this manifest

... so I though that since the MIT/Apache-2.0 combo might be the closest thing there is to a standard license for rust projects, extra files should not be needed. But if there is need for a separate file, I can add it. Would it be ok to put both licenses in the same file, or do I need separate files (as done in e.g. lazy-static)?

@kaj kaj closed this as completed in 6131ade Dec 17, 2019
kaj added a commit that referenced this issue Dec 25, 2019
@kaj
Release 0.12.0
5038b18 
* Issue #54: Add a LICENSE file.
* PR #57: Allow channel string in rgba()
* Issue #58: Let ructe::Error implement std::error::Error.
* Issue #59: Improve `@import` and media rules.
* Implement `@error` and `@warn` directives.
* Improve string unquoting, including multi-position numerical
  escapes.
* Improve at-rule parsing.
* Fix strange operator handling.
* Implement modulo operator.
* Fix line breaks in comments.
* Handle bad argument to `random()` function.
* Update test suite to e9e219bdf (2019-12-19).
* Some refactorig and clean-up.

Thanks to @emielbeinema, @maxbrunsfeld, and @Boiethios for contributed
code and suggestios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxbrunsfeld @kaj