CommPrefix bump to 5 + others #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re on different servers Watches the combat log for actions by/against players on other servers, storing their realm. The realm is not available during the CHAT_MSG_COMBAT_HONOR_GAIN event. There are some niche cases where the realm may still be incorrect: if you're simultaneously fighting two players from different realms with the exact same name.
Not used anywhere in the GUI or base code, this is an advanced function to be called manually by players who somewhat know what they're doing.
|
Merged. So when is the best time time to release the update? Today I suppose? |
|
Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't release this midweek. If you can't accept the PR and tag a release before tomorrow (Thursday) please wait until Monday. I don't want to have a mess of half-updated players over the weekend to deal with.
In world pvp, the chatlog was showing messages like "Enemyplayer died, honorable kill 5" even if Enemyplayer was actually on another server. This means the kill counter was being saved under Enemyplayer-Arugal when it should be saved under Enemyplayer-Yojamba. I can get their realm from the UNIT_DIED subevent of the COMBAT_LOG event, and store it in a cache. This isn't 100% if there are two players with the same name from different realms both doing pvp at the same time. But that should be niche enough to not matter.
Also made a bunch of functions local that were leaking into the global namespace. If testing becomes a problem later on I might shove them into the HonorSpy: namespace instead.