Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't release this midweek. If you can't accept the PR and tag a release before tomorrow (Thursday) please wait until Monday. I don't want to have a mess of half-updated players over the weekend to deal with.
In world pvp, the chatlog was showing messages like "Enemyplayer died, honorable kill 5" even if Enemyplayer was actually on another server. This means the kill counter was being saved under Enemyplayer-Arugal when it should be saved under Enemyplayer-Yojamba. I can get their realm from the UNIT_DIED subevent of the COMBAT_LOG event, and store it in a cache. This isn't 100% if there are two players with the same name from different realms both doing pvp at the same time. But that should be niche enough to not matter.
Also made a bunch of functions local that were leaking into the global namespace. If testing becomes a problem later on I might shove them into the HonorSpy: namespace instead.