Skip to content

Commit

Permalink
[src] fix embedding training bug for RNNLM without letter features (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
hainan-xv authored and danpovey committed Aug 2, 2018
1 parent 68c926a commit 04027ee
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/rnnlm/rnnlm-embedding-training.cc
Expand Up @@ -175,7 +175,7 @@ void RnnlmEmbeddingTrainer::Train(
if (config_.l2_regularize > 0.0) {
BaseFloat l2_term = -2 * config_.l2_regularize;
if (l2_term != 0.0) {
embedding_deriv->AddToRows(l2_term, active_words, embedding_mat_);
embedding_deriv->AddRows(l2_term, *embedding_mat_, active_words);
}
}
BaseFloat scale = 1.0;
Expand Down Expand Up @@ -229,8 +229,8 @@ void RnnlmEmbeddingTrainer::TrainBackstitch(
if (config_.l2_regularize > 0.0 && !is_backstitch_step1) {
BaseFloat l2_term = -2 * config_.l2_regularize;
if (l2_term != 0.0) {
embedding_deriv->AddMat(1.0 / (1.0 + config_.backstitch_training_scale) *
l2_term, *embedding_mat_);
embedding_deriv->AddRows(l2_term / (1.0 + config_.backstitch_training_scale),
*embedding_mat_, active_words);
}
}
BaseFloat scale = 1.0;
Expand Down

0 comments on commit 04027ee

Please sign in to comment.