NetworkNode types

[eliemichel]

The documentation admits that "we have a slightly messy layout", and my question might be naive, but why not writing a different object for each type of node (that may inherit from a virtual NetworkNode class)?

[danpovey]

The reason is that in the code, NetworkNodes are mostly accessed as you
would a struct, and we deal with vectors of them. If there were
polymorphism involved, we could no longer deal with vectors of NetworkNodes
but we'd have to deal with vectors of pointers to them; and accessing their
data members would involve about 3 times as much code as it currently does,
as we'd have to figure out which type it was and do an appropriate type of
cast.

Dan

On Wed, Sep 16, 2015 at 5:54 PM, Elie Michel notifications@github.com
wrote:

The documentation admits that "we have a slightly messy layout", and my
question might be naive, but why not writing a different object for each
type of node (that may inherit from a virtual NetworkNode class)?

—
Reply to this email directly or view it on GitHub
#144.

[eliemichel]

Got you, it indeed looks like a good reason. =)