Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenFST FstPrinter.Print signature has changed between 1.7.2 and 1.7.7 #4131

Open
kkm000 opened this issue Jun 24, 2020 · 2 comments
Open

OpenFST FstPrinter.Print signature has changed between 1.7.2 and 1.7.7 #4131

kkm000 opened this issue Jun 24, 2020 · 2 comments
Assignees
Labels
bug stale-exclude Stale bot ignore this issue

Comments

@kkm000
Copy link
Contributor

kkm000 commented Jun 24, 2020

From https://groups.google.com/forum/#!topic/kaldi-help/qRp-TquUPHA

/home/jupyter/rob/espnet/kaldi/tools/openfst-1.7.7/include/fst/script/print-impl.h:46:8: note: candidate: void fst::FstPrinter<Arc>::Print(std::ostream&, const string&) [with Arc = fst::ArcTpl<fst::CompactLatticeWeightTpl<fst::LatticeWeightTpl<float>, int> >; std::ostream = std::basic_ostream<char>; std::__cxx11::string = std::__cxx11::basic_string<char>]
   void Print(std::ostream &ostrm, const std::string &dest) {
        ^~~~~
/home/jupyter/rob/espnet/kaldi/tools/openfst-1.7.7/include/fst/script/print-impl.h:46:8: note:   no known conversion for argument 1 from ‘std::ostream* {aka std::basic_ostream<char>*}’ to ‘std::ostream& {aka std::basic_ostream<char>&}’

1.7.2 indeed had void Print(std::ostream *ostrm, const string &dest):

https://github.com/kkm000/openfst/blob/0bca6e76d24647427356dc242b0adbf3b5f1a8d9/src/include/fst/script/print-impl.h#L46-L57

Patch from @nshmyrev: alphacep@719d385

@kkm000
Copy link
Contributor Author

kkm000 commented Jul 19, 2020

Blocked by kkm000/openfst#30

@stale
Copy link

stale bot commented Sep 17, 2020

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.

@stale stale bot added the stale Stale bot on the loose label Sep 17, 2020
@kkm000 kkm000 added stale-exclude Stale bot ignore this issue and removed stale Stale bot on the loose labels Mar 11, 2021
mbakke pushed a commit to guix-mirror/guix that referenced this issue May 15, 2022
Kaldi is currently broken with openfst versions newer than 1.7.3 as it changed
some of its function signatures.

Once Kaldi is patched/fixed, this should be removed.

Reference Issues:
- kaldi-asr/kaldi#4131
- kaldi-asr/kaldi#4393

* gnu/packages/machine-learning.scm (openfst-1.7.3): New variable.

Signed-off-by: Ludovic Courtès <ludo@gnu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale-exclude Stale bot ignore this issue
Projects
None yet
Development

No branches or pull requests

1 participant