[not-for-merge] Makefile2cmake conversion script #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed by a bot strictly because of inactivity. This does not mean that we think that this issue is not important! If you believe it has been closed hastily, add a comment to the issue and mention @kkm000, and I'll gladly reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more like a proof-of-concept than anything I intend to get merged soon.
There are requests coming from different parties wanting to use CMake, for discussion see e.g. #1582. While I'm convinced there is not a substantial benefit in switching to it, perhaps we could exploit the fact that our Makefiles are usually very simple and have pretty simple (and systematic) structure. SIDENOTE: the exception is the tensorflow rescoring.
Being able to generate the cmake build infrastructure also simplifies the build under windows.
The input assumption is that the configure script has been run and kaldi.mk does exist -- after that, everything can be figured out fairly easily. For windows, the kaldi.mk is written by the user (it's essentially a template with a couple of directories/paths to be filled out).
There is still a lot of rough edges, but it's fairly usable for a person who knows what is doing (probably only me :-/ )