Fix speed-perturbatin for swbd + execuation permissions for some fisher_swbd scripts #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpovey
reviewed
Feb 4, 2018
| @@ -108,7 +108,7 @@ dir=${dir}$suffix | |||
| build_tree_train_set=train_nodup | |||
| train_set=train_nodup_sp | |||
| build_tree_ali_dir=exp/tri5a_ali | |||
| treedir=exp/chain/tri6_tree | |||
| treedir=exp/chain/tri5_tree | |||
There was a problem hiding this comment.
I think you should change this line back because it could problems when running from a later --stage.
|
|
||
| rm -r ${destdir}_speed0.9 ${destdir}_speed1.1 | ||
| utils/copy_data_dir.sh --spk-prefix sp1.0- --utt-prefix sp1.0- ${srcdir} data/temp0 |
There was a problem hiding this comment.
since you are already creating the dir with _speed0.9 and _speed1.0 as suffixes, I think it would be clearer and more consistent to use _speed1.0 as the suffix for this.
danpovey
added a commit
to danpovey/kaldi
that referenced
this pull request
Feb 11, 2018
danpovey
added a commit
that referenced
this pull request
Feb 11, 2018
LvHang
pushed a commit
to LvHang/kaldi
that referenced
this pull request
Apr 14, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.