Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[not-for-merge] [src] Adding binary lattice-to-ngram-counts #2778

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

david-ryan-snyder
Copy link
Contributor

This PR adds a binary called lattice-to-ngram-counts that computes n-label softcounts over input lattices.

Note that this binary may need to be used in conjunction with lattice-expand-ngram (https://github.com/kaldi-asr/kaldi/blob/master/src/latbin/lattice-expand-ngram.cc) so that each arch as a unique n-label history.

The PR is currently "not-for-merge" but may be added to the main branch at some point.

@m-wiesner

@david-ryan-snyder
Copy link
Contributor Author

@m-wiesner was this code, or something similar to it, ever added to the main branch?

@stale
Copy link

stale bot commented Jun 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale bot on the loose label Jun 19, 2020
@kkm000 kkm000 removed the stale Stale bot on the loose label Jul 17, 2020
@kkm000
Copy link
Contributor

kkm000 commented Jul 17, 2020

@david-ryan-snyder, @m-wiesner, where we are at this?

@kkm000 kkm000 added the waiting-for-feedback Reporter's feedback has been requested label Jul 17, 2020
@stale
Copy link

stale bot commented Sep 15, 2020

This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.

@stale stale bot added the stale Stale bot on the loose label Sep 15, 2020
@kkm000 kkm000 removed the stale Stale bot on the loose label Nov 25, 2020
@kkm000
Copy link
Contributor

kkm000 commented Nov 25, 2020

@david-ryan-snyder, @m-wiesner, friendly ping?

@danpovey
Copy link
Contributor

I think it's OK to merge but it's not used in any recipes. We can just leave the PR up, I think, in case people need it, and if it seems useful for anything we want to commit we can merge it.

@kkm000 kkm000 added stale-exclude Stale bot ignore this issue Priority: lower It will take us a while to get to this, be patient labels Nov 25, 2020
@kkm000
Copy link
Contributor

kkm000 commented Nov 25, 2020

Agree, it makes no sense to maintain unused code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: lower It will take us a while to get to this, be patient stale-exclude Stale bot ignore this issue waiting-for-feedback Reporter's feedback has been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants