Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix/update kaldi for openfst 1.8 #4716

Closed
wants to merge 7 commits into from
Closed

[WIP] Fix/update kaldi for openfst 1.8 #4716

wants to merge 7 commits into from

Commits on Mar 24, 2022

  1. Stop using fst/types.h shims 

    The type shims have been removed from openfst since 1.8.2
    @auroraanon38
    auroraanon38 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    5850179 View commit details
    Browse the repository at this point in the history

  2. Use C++17 because openfst requires it

    @auroraanon38
    auroraanon38 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    ebfd4ca View commit details
    Browse the repository at this point in the history

  3. Try not to namespace type shims 

    As far as I can see there's no real reason to namespace these
bindings.
    @auroraanon38
    auroraanon38 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    2fd7a6c View commit details
    Browse the repository at this point in the history

  4. Use openfst renamed variables 

    openfst renamed FLAGS_fst_weight_separator to
FST_FLAGS_fst_weight_separator, as well as a number of other variables
in their codebase between 1.7.3 and 1.8.2
    @auroraanon38
    auroraanon38 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    e5c068e View commit details
    Browse the repository at this point in the history

  5. Use openfst renamed arcmap stuff

    @auroraanon38
    auroraanon38 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    18b826b View commit details
    Browse the repository at this point in the history

  6. Do not create pointers of references of os stream 

    openfst changed the function signature to a reference instead of a
pointer.
    @auroraanon38
    auroraanon38 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    0ed22f2 View commit details
    Browse the repository at this point in the history

  7. Cleanup some namespaced number usage

    @auroraanon38
    auroraanon38 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    2b82124 View commit details
    Browse the repository at this point in the history