Support Bootstrap 5

[simonihmig]

Trying to summarize what the minimum changes are to support Bootstrap 5.

• Support v5 in the addon's index.js. PR: Support Bootstrap v5 in addon index.js #1496
• Add support for --bootstrap-version=5 in the default blueprint (with v4 still being the default for now) PR: Support Bootstrap5 in default blueprint #1497
• Update setup docs Add BS5 and remove BS3 instructions to docs app #1617
• Setup CI for BS5. PR: Add experimental/incomplete Bootstrap 5 support to existing components #1499
• Deprecate BS3. Only loosely related to BS5 support, but I think we don't want to support all three versions for an extended time. But to introduce BS5 support without a major bump, we might have to do it for some time. As there are not many renamed classes, this seems doable. PR: Deprecate Bootstrap 3 support #1536
• Update markup for Accordion, see https://getbootstrap.com/docs/5.0/components/accordion/ PR: Add Bootstrap v5 support for accordions #1561
• Update markup for Forms, see https://getbootstrap.com/docs/5.0/migration/#forms. PR: Update forms for Bootstrap 5 #1512
• Update markup for Buttons, see https://getbootstrap.com/docs/5.0/migration/#buttons PR: Remove .btn-block support for Bootstrap 5 #1537
• Update toggle buttons for ButtonGroups, see https://getbootstrap.com/docs/5.0/migration/#buttons PR: Add Bootstrap v5 support for ButtonGroup #1540
• Update markup for Navbars, see https://getbootstrap.com/docs/5.0/migration/#navbars PR: Add Bootstrap v5 support for Navbars #1597
• Update markup for Popovers, see https://getbootstrap.com/docs/5.0/migration/#popovers. PR: Update Tooltips and Popovers for Bootstrap 5 #1502
• Update markup for Tooltips, see https://getbootstrap.com/docs/5.0/migration/#tooltips. PR: Update Tooltips and Popovers for Bootstrap 5 #1502
• BS4 uses popper.js v2. Do we have to follow here? ember-popper hasn't been maintained much, https://github.com/alexlafroscia/ember-popper-modifier seems like a more modern and up to date solution, and uses v2.
• BS5 drops support for IE11 🎉. While this doesn't really affect us technically, it at least makes dropping support in our addon even more desirable. Probably in our v5, maybe including requiring Ember 4.0 as the minimum version then? Drop IE11 support #1596
• Change use of .sr-only to .visually-hidden
• Fix modal close button, see this comment Fix BS5 markup for modal close button #1614

Any kind of contributions (PRs, documentation, testing) highly welcome! Just comment here if you are interested in helping out!

/cc @jelhan

[vlascik]

Also, modal dialog's close button changed the class from close to btn-close.

I have a script with more of the changes to bootstrap classes listed at https://github.com/vlascik/bootstrap4-to-5-migrator , might be of some use to you.

[simonihmig]

Thanks @vlascik, I'll look into it! Or do you have time for a PR? 😀

[simonihmig]

Also, modal dialog's close button changed the class from close to btn-close.

#1614 should fix this.

[simonihmig]

Seems we are done here! 🎉

Wondering if we should make BS5 the default for our upcoming v5? 🤔

Changing the default is not really a breaking change I think, as the version is "pinned" in ember-cli-build.js, but the new major seems a good moment to do the switch nevertheless!? @jelhan thoughts?

[vst]

Changing the default is not really a breaking change I think, as the version is "pinned" in ember-cli-build.js, but the new major seems a good moment to do the switch nevertheless!? @jelhan thoughts?

I agree.

[jelhan]

Changing the default is not really a breaking change I think, as the version is "pinned" in ember-cli-build.js, but the new major seems a good moment to do the switch nevertheless!? @jelhan thoughts?

Fully agree. Let's switch to Bootstrap 5. 👍

[vst]

Quick feedback, FWIW: I have been using v5.0.0-beta.0 on BS5 for the last few days. I did not notice any regressions or errors so far, at least not due to ember-bootstrap.

[simonihmig]

Thanks @vst for the feedback! There was one issue related to alerts though, which was fixed in #1620, but this is yet to be released! fyi

[simonihmig]

BTW, I started working migrating the docs app (ember-bootstrap.com) to BS5, and noticed some missing margins for forms. So some minor issues still need to be sorted out...

[vst]

@simonihmig Got it, thanks! Will report anything we bump into.

[martinbarilik]

beta.0 still requires "@ember/render-modifiers": "^1.0.2", can we drop it and use 2.0.0 instead so we remove

Versions of modifier manager capabilities prior to 3.22 have been deprecated. You must update to the 3.22 capabilities.

message ? 2.0.0 render-modifier was released just recently

[simonihmig]

@martinbarilik sure! I have yet to setup a successor to dependabot here, that would do these dependency updates automatically. But if you have the time, a PR would certainly be welcome! :)