Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm target #56

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

SuperCaliMan
Copy link

Hi, thanks for getting into this project!

Checklist for your PR:

  • Check if there's any open issue
  • Please file your request against the develop branch

Description of your changes

Hi i implemented wasm target, to import and use this library in a wasm application.

How has this been tested?

I test it with OpenID link

Is this a (API-) breaking change?

No

@SuperCaliMan SuperCaliMan changed the base branch from main to develop June 20, 2024 07:40
@kalinjul
Copy link
Owner

Hi, this only adds wasm target without providing implementation, right?
Why does this need ktor eap?

@SuperCaliMan
Copy link
Author

SuperCaliMan commented Jun 21, 2024

Hi, this only adds wasm target without providing implementation, right? Why does this need ktor eap?

Ktor support wasm target only in eap

@ralfstuckert
Copy link

Any news on this PR? This feature would be a great benefit

@kalinjul
Copy link
Owner

Ok so there are some things in this PR I'd like to discuss, i'll put my questions in a review.
But also I'd like to wait for a stable ktor release supporting wasm before requiring a beta or EAP in this library.

Comment on lines -169 to +171
val request = runBlocking { // there is no suspending happening here
val request = scope.async { // there is no suspending happening here
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the difference between runBlocking and using a custom scope with await?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a better async management

@maicol07
Copy link
Contributor

Hi, any news on this? Ktor 3 is now in RC and it will soon be stable

@SuperCaliMan
Copy link
Author

Hi, any news on this? Ktor 3 is now in RC and it will soon be stable

Hi, I will update this PR when Ktor 3 is released in the stable channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants