-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasm target #56
base: develop
Are you sure you want to change the base?
Add wasm target #56
Conversation
Hi, this only adds wasm target without providing implementation, right? |
Ktor support wasm target only in eap |
Any news on this PR? This feature would be a great benefit |
Ok so there are some things in this PR I'd like to discuss, i'll put my questions in a review. |
...Main/kotlin/org/publicvalue/multiplatform/oidc/appsupport/PlatformOidcCodeAuthFlow.wasmJs.kt
Outdated
Show resolved
Hide resolved
val request = runBlocking { // there is no suspending happening here | ||
val request = scope.async { // there is no suspending happening here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the difference between runBlocking and using a custom scope with await?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a better async management
oidc-core/src/commonMain/kotlin/org/publicvalue/multiplatform/oidc/types/Jwt.kt
Outdated
Show resolved
Hide resolved
Hi, any news on this? Ktor 3 is now in RC and it will soon be stable |
Hi, I will update this PR when Ktor 3 is released in the stable channel. |
Hi, thanks for getting into this project!
Checklist for your PR:
Description of your changes
Hi i implemented wasm target, to import and use this library in a wasm application.
How has this been tested?
I test it with OpenID link
Is this a (API-) breaking change?
No