Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min max values #32

Closed
gerard33 opened this issue Jan 31, 2019 · 3 comments
Closed

Min max values #32

gerard33 opened this issue Jan 31, 2019 · 3 comments
Labels
bug Something isn't working enhancement Something that can be improved

Comments

@gerard33
Copy link
Contributor

I have 2 request regarding the min-max values.

  • The time is shown with AM-PM. Is it possible to also configure a 24 hours clock?
  • If you set graph: false under show then min-max (extrema) is not shown anymore. Is it possible to still show these values even when the graph is not shown?

Some more info here.
@kalkih
Copy link
Owner

kalkih commented Jan 31, 2019

  • The time is shown with AM-PM. Is it possible to also configure a 24 hours clock?

A actually added just this earlier today (8464a85), will be in the next release!

  • If you set graph: false under show then min-max (extrema) is not shown anymore. Is it possible to still show these values even when the graph is not shown?

Good catch, will fix!

@kalkih kalkih added bug Something isn't working enhancement Something that can be improved labels Jan 31, 2019
@kalkih
Copy link
Owner

kalkih commented Feb 2, 2019

Okay, so the extrema was actually showing, but it did not render or update until the next time one of the entities were updated.
It's fixed now and will be in the next release.

kalkih added a commit that referenced this issue Feb 2, 2019
@kalkih
Make sure extrema update force rerender (#32)
67c2a3e
@kalkih
Copy link
Owner

kalkih commented Feb 3, 2019

Both issues addressed with v0.2.1.
Use new hour24 for 24 hour clock.
Thanks!

@kalkih kalkih closed this as completed Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement Something that can be improved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kalkih @gerard33