Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artwork option like in the lovelace-media player card #333

Closed
nibblerrick opened this issue Jun 11, 2020 · 5 comments · Fixed by #331
Closed

Artwork option like in the lovelace-media player card #333

nibblerrick opened this issue Jun 11, 2020 · 5 comments · Fixed by #331
Labels
enhancement New feature or request

Comments

@nibblerrick
Copy link

Hi,

thanks for your card, I'm using it quite some time now and really enjoy it. However I am wondering if it may be possible to have an option for the artwork like in the default card. I hope I haven't overseen this featurerequest in the issues. With full-cover the card becomes somewhat large, with no cover the artwork is a bit tiny. With cover it looks like this and is very cropped:
chrome_2020-06-11_09-27-55
The original lovelacecard (which lacks many features... :-) ) the artworkstyle looks like this:
chrome_2020-06-11_09-28-07
I think that's a nice way to show the full cover as large as possible without being too big.
What do you think?
If this has been considered in the past and won't happen feel free to close the isse.

Thanks

Nico

@kalkih kalkih added the enhancement New feature or request label Jun 11, 2020
@kalkih kalkih linked a pull request Jun 11, 2020 that will close this issue
@kalkih
Copy link
Owner

kalkih commented Jun 11, 2020

Hello,
Indeed, the default card is looking great with the fresh update, great work @zsarnett!

@SBado has already started working on adding this kind of artwork option to the card with some great progress, see here #331.

Hope you are ok with us borrowing the design @zsarnett, otherwise let me know.

@nibblerrick
Copy link
Author

I looked through the issues but have missed to look at the PRs. Looks very good, as it is of course exactly that I thought of. Thanks @SBado!
Should this issue be closed therefore now or remain open till that PR is merged for informational purpose?

@kalkih
Copy link
Owner

kalkih commented Jun 11, 2020

Let's keep it open until the PR is complete and merged 🙂

Have a great day.

@nibblerrick
Copy link
Author

Thanks, same to you!

kalkih added a commit that referenced this issue Aug 3, 2020
Co-authored-by: Stefano Badoino <s.badoino@ext.sirti.it>
Co-authored-by: Karl Kihlström <mrkihlstrom@gmail.com>
@kalkih kalkih closed this as completed Aug 3, 2020
@nibblerrick
Copy link
Author

Thanks, looks very good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants