New artwork type #331
Merged
New artwork type #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Edit: Would however prefer if that was done in another PR. |
kalkih
reviewed
Jun 10, 2020
|
When player isn't active (paused e.t.c.) we should revert to default UI colors. |
kalkih
reviewed
Jun 13, 2020
|
Need to make sure the player reverts to default colors if the "idle_view" state is active.
Easily reproduce with the following config ...
idle_view:
when_paused: true |
|
Utilizing the css variables was great, removed a lot of unnecessary code. 👍 |
|
+1 for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new artwork type to mimic stock media player card look&feel:
I simply "stole" the code from the stock card, all credits go to @zsarnett, as far as I know (he's the one mentioned in Home Assistant 0.107 release notes, here).
The only problem I'm facing is that for the life of me I cannot build the code using rollup. I mean, the build completes successfully, but the card doesn't work and Chrome debugger shows a "require is not defined" error upon opening the page. I had to switch to webpack to make everything work.
@kalkih If you are interested, can I ask you some support about rollup?