Added note about type:service + spotcast #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it pretty difficult to spot the type:service option, and get it working with my Google Setup. I sadly wish to have Sonos around - however, with 6 Google devices, i'm not going to swap them, anytime soon. So for everyon with Google, i guess this could be informative for other people, too. Thanks for a great solution, btw :-) I guess you're taking my 1. place for the best custom module - that's for sure!
|
Hey, thanks for the PR, this could indeed be useful for other people. |
kalkih
reviewed
Dec 9, 2019
And fixed typos, btw.
exetico
commented
Dec 11, 2019
|
Damn. Missed the |
|
I guess that's all. Next time, i'll try and remember to use the preview-function before pushing changes ;-) |
|
Great! Thanks for the PR, merging now 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it pretty difficult to spot the type:service option, and get it working with my Google Setup. I sadly wish to have Sonos around - however, with 6 Google devices, i'm not going to swap them, anytime soon.
So for everyon with Google, i guess this could be informative for other people, too.
Thanks for a great solution, btw :-) I guess you're taking my 1. place for the best custom module - that's for sure!