Add hooks for start/stop STT processing #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaboniface
force-pushed
the
add-stt-processing-hooks
branch
from
b41bfa8
to
8f4ada3
Compare
I find it very useful to know via hook feedback when my Kalliope actually stops *listening* (i.e. the microphone is no longer actively recording) and when STT starts processing, especially since with some STT providers this latter step can take some amount of time. This alters the behaviour of the old on_start/stop_listening hooks to fire inside the STT Utils when the listener actually stops listening and the callback is fired, and then adds two new hooks around said callback: on_start_stt_processing and on_stop_stt_processing. These are optional like most others, but could be used if desired. With this new setup, the on_start_listening/on_stop_listening only fire when the microphone is in use by the STT library; I can't see a good reason why this wouldn't happen, but am open to feedback if there is a better place to put these instead.
joshuaboniface
force-pushed
the
add-stt-processing-hooks
branch
2 times, most recently
from
a1014b3
to
2c4fba1
Compare
joshuaboniface
force-pushed
the
add-stt-processing-hooks
branch
from
2c4fba1
to
ae66b17
Compare
|
Should be good now, new tests passing successfully. |
|
Thx |
|
Glad to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it very useful to know via hook feedback when my Kalliope
actually stops listening (i.e. the microphone is no longer actively
recording) and when STT starts processing, especially since with some
STT providers this latter step can take some amount of time.
This alters the behaviour of the old on_stop_listening hook to fire
inside the STT Utils when the listener actually stops listening and the
callback is fired, and then adds two new hooks around said callback:
on_start_stt_processing and on_stop_stt_processing. These are optional
like most others, but could be used if desired.
With this new setup, the on_start_listening/on_stop_listening only fire
when the microphone is in use by the STT library; I can't see a good
reason why this wouldn't happen, but am open to feedback if there is a
better place to put these.