Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hooks for start/stop STT processing #688

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Add hooks for start/stop STT processing #688

merged 3 commits into from
Jun 6, 2023

Commits on Jun 6, 2023

  1. Add hooks for start/stop STT processing 

    I find it very useful to know via hook feedback when my Kalliope
actually stops *listening* (i.e. the microphone is no longer actively
recording) and when STT starts processing, especially since with some
STT providers this latter step can take some amount of time.

This alters the behaviour of the old on_start/stop_listening hooks to
fire inside the STT Utils when the listener actually stops listening and
the callback is fired, and then adds two new hooks around said callback:
on_start_stt_processing and on_stop_stt_processing. These are optional
like most others, but could be used if desired.

With this new setup, the on_start_listening/on_stop_listening only fire
when the microphone is in use by the STT library; I can't see a good
reason why this wouldn't happen, but am open to feedback if there is a
better place to put these instead.
    @joshuaboniface
    joshuaboniface committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    8377f41 View commit details
    Browse the repository at this point in the history

  2. Add some helpful time output to the messages

    @joshuaboniface
    joshuaboniface committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    311675c View commit details
    Browse the repository at this point in the history

  3. Add tests for new hooks

    @joshuaboniface
    joshuaboniface committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    ae66b17 View commit details
    Browse the repository at this point in the history