-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for Flint 3 #162
Conversation
great for taking care of this! the changes seem to be pretty minimal, given the changes in arb/flint. That's a big plus! |
274fb2f
to
7c3fcd4
Compare
09c208e
to
df6b0cd
Compare
Now |
I did some more testing and everything seems to work well! This is then ready for merging after #172 |
@Joel-Dahne You are on a spree :) |
Flint version 3 merges all Arb with Flint (together with a lot of other packages). We therefore only have to depend on Flint now.
There was a breaking change in the order of the parameters.
This is commit 6fb6a8d95e7a2403746e7e260b2375c78160e264
You are doing a good job in keeping up! This should be ready to be merged now. Then I have one more thing I want to add, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look brief look at this (again).
It seems that almost all changes are libarb
→ libflint
rename?
Or is there something else hidden?
That is basically it. The only other main change is the reordering for the poly structs, but that you don't really have to care about from Julia. Then it is just documentation changes and making use of some of the newly added functions in Flint. |
Flint 3 is getting closer, an https://groups.google.com/g/flint-devel/c/xc5lFBU9a94 was tagged about a month ago. With this release the Arb package will now be a part of Flint instead of being a separate package. That means that we have to make some minor updates to the package.
The main changes in this PR are:
libflint
fromFLINT_jll
instead oflibarb
fromArb_jll
flint-3.0.0-alpha1
tag of Flint. This adds a few new methods but also removes quite a lot of methods which are now based on generic versions in Flint.There is still no
FLINT_jll
for Flint 3 so the tests won't be able to run here. To run it locally you need to build an appropriate version of Flint and then add the lineto the file
LocalPreferences.toml
at the root of this repository.Once Flint 3 is release and
FLINT_jll
is updated we can move forward with this PR.