Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for Flint 3 #162

Merged
merged 12 commits into from
Oct 29, 2023
Merged

Preparation for Flint 3 #162

merged 12 commits into from
Oct 29, 2023

Conversation

Joel-Dahne
Copy link
Collaborator

@Joel-Dahne Joel-Dahne commented Jul 25, 2023

Flint 3 is getting closer, an https://groups.google.com/g/flint-devel/c/xc5lFBU9a94 was tagged about a month ago. With this release the Arb package will now be a part of Flint instead of being a separate package. That means that we have to make some minor updates to the package.

The main changes in this PR are:

  • Use libflint from FLINT_jll instead of libarb from Arb_jll
  • Update the poly structs according to the change in Flint. This is a breaking change in the sense that it changes the order of the memory layout, but is unlikely to matter when coding in Julia.
  • Update the parser and reparse the documentation, based on the flint-3.0.0-alpha1 tag of Flint. This adds a few new methods but also removes quite a lot of methods which are now based on generic versions in Flint.

There is still no FLINT_jll for Flint 3 so the tests won't be able to run here. To run it locally you need to build an appropriate version of Flint and then add the line

[FLINT_jll]
libflint_path = "/path/to/flint2/libflint.so"

to the file LocalPreferences.toml at the root of this repository.

Once Flint 3 is release and FLINT_jll is updated we can move forward with this PR.

@kalmarek
Copy link
Owner

great for taking care of this!

the changes seem to be pretty minimal, given the changes in arb/flint. That's a big plus!

@Joel-Dahne
Copy link
Collaborator Author

Now FLINT_jll has been updated to version 3, which means this PR is ready. However, I want to do some more testing to see if everything works well before merging it.

@Joel-Dahne
Copy link
Collaborator Author

I did some more testing and everything seems to work well! This is then ready for merging after #172

@Joel-Dahne Joel-Dahne marked this pull request as ready for review October 26, 2023 13:53
@kalmarek
Copy link
Owner

@Joel-Dahne You are on a spree :)

@Joel-Dahne
Copy link
Collaborator Author

You are doing a good job in keeping up!

This should be ready to be merged now. Then I have one more thing I want to add, union and intersection for polynomials and midpoint for Acb. After that I think we could be ready for a 1.0 release?

Copy link
Owner

@kalmarek kalmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look brief look at this (again).
It seems that almost all changes are libarblibflint rename?
Or is there something else hidden?

src/Arblib.jl Outdated Show resolved Hide resolved
@Joel-Dahne
Copy link
Collaborator Author

I had a look brief look at this (again). It seems that almost all changes are libarblibflint rename? Or is there something else hidden?

That is basically it. The only other main change is the reordering for the poly structs, but that you don't really have to care about from Julia. Then it is just documentation changes and making use of some of the newly added functions in Flint.

@Joel-Dahne Joel-Dahne merged commit 436ac3d into master Oct 29, 2023
13 checks passed
@Joel-Dahne Joel-Dahne deleted the flint3 branch October 29, 2023 07:02
@Joel-Dahne Joel-Dahne mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants