Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/groups core #31

Merged
merged 8 commits into from
Apr 30, 2021
Merged

Enh/groups core #31

merged 8 commits into from
Apr 30, 2021

Conversation

kalmarek
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #31 (0fefd3c) into master (2f90f54) will increase coverage by 1.29%.
The diff coverage is 96.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   88.53%   89.83%   +1.29%     
==========================================
  Files          10        9       -1     
  Lines         445      472      +27     
==========================================
+ Hits          394      424      +30     
+ Misses         51       48       -3     
Flag Coverage Δ
unittests 89.83% <96.59%> (+1.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/characters.jl 77.89% <87.50%> (+2.38%) ⬆️
src/projections.jl 84.21% <91.66%> (ø)
src/actions.jl 93.75% <100.00%> (+2.08%) ⬆️
src/cmmatrix.jl 100.00% <100.00%> (ø)
src/dixon.jl 98.18% <100.00%> (ø)
src/eigenspacedecomposition.jl 95.20% <100.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f90f54...0fefd3c. Read the comment docs.

@kalmarek
Copy link
Owner Author

@blegat if you don't see anything jarring, let's merge this, then we can have a chat over examples in SumOfSquares.jl and related topics ;)

Copy link
Collaborator

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it even fixes a few issues for SumOfSquares

@kalmarek kalmarek merged commit 57e61c3 into master Apr 30, 2021
@blegat blegat mentioned this pull request May 11, 2021
@kalmarek kalmarek deleted the enh/GroupsCore branch September 1, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants