-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEM 2175 - Add Captions styling to ExoPlayerWrapper #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GouravSna
changed the title
Fem 2175
FEM 2175 - Add Captions styling to ExoPlayerWrapper
Oct 26, 2018
- Edge color was assigned to wrong value
giladna
reviewed
Nov 5, 2018
playkit/src/main/java/com/kaltura/playkit/player/PlayerController.java
Outdated
Show resolved
Hide resolved
noamtamim
suggested changes
Nov 5, 2018
playkit/src/main/java/com/kaltura/playkit/player/ExoPlayerWrapper.java
Outdated
Show resolved
Hide resolved
playkit/src/main/java/com/kaltura/playkit/player/ExoPlayerWrapper.java
Outdated
Show resolved
Hide resolved
playkit/src/main/java/com/kaltura/playkit/player/ExoPlayerWrapper.java
Outdated
Show resolved
Hide resolved
playkit/src/main/java/com/kaltura/playkit/player/SubtitleStyleSettings.java
Show resolved
Hide resolved
- Local variable for subtitleView in ExoPlayerWrapper
noamtamim
suggested changes
Nov 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the the minor comment, looks good now. But don't merge yet.
playkit/src/main/java/com/kaltura/playkit/player/SubtitleStyleSettings.java
Outdated
Show resolved
Hide resolved
giladna
approved these changes
Nov 7, 2018
OrenMe
reviewed
Nov 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add parsable so application(or Kaltura player) can save user settings and apply them on each player instantiation.
- Shorten builder set/get names and omit
subtitles
, e,g.setSubtitleBackgroundColor
==>setBackgroundColor
noamtamim
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create SubtitlesStyle using,
Attributes are:
Then set the
subtitleStyleSettings
inPlayerSettings
,player.getSettings().setSubtitleStyle(subtitleStyleSettings);
To update the subtitles create another object using the above method and then call
updateSubtitleStyle(..)
onplayer
object ,player.updateSubtitleStyle(subtitleStyleSettings);