Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dropped Frames Metric #329

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

TheoBendixson
Copy link
Contributor

Description of the Changes

At MotorTrend, we have been using total number of dropped frames in our analytics. It would be nice to access them from PKPlaybackInfo, in Objective-C.

CheckLists

  • [*] changes have been done against master branch, and PR does not conflict

  • [*] new unit / functional tests have been added (whenever applicable)
    Not sure it makes sense to add a unit test for this, since this code simply passes the value from AVPlayerItemAccessLogEvent. We would need to mock one of those objects (kinda cumbersome no?). That said, I did install the branch via Cocoapods to make sure it compiles properly. No errors on my end.

  • [*] test are passing in local environment
    Ditto from above comment.

  • [*] Travis tests are passing (or test results are not worse than on master branch :))

  • [*] Docs have been updated
    I added a comment describing what the property does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant