Expose Creative ID and Advertiser Name #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamtamim
suggested changes
Mar 26, 2019
x-NR-x
approved these changes
Mar 26, 2019
noamtamim
approved these changes
Mar 26, 2019
x-NR-x
added a commit
that referenced
this pull request
Apr 2, 2019
* develop: FEM-2475 - Fixed audio track crash, the mediaType returned from the option of audible tracks has changed. (#339) FEM-2466 Swift 4.2 (#338) Expose Creative ID and Advertiser Name (#330) FEM-2464 Expose player volume (#336) FEM-2463 There is no off state for audio tracks, it should default to auto. (#335) FEM-2393 Cap seek target (#333) FEM-2451 Player doesn't start playing once ready (#332) # Conflicts: # Classes/Player/PlayerController.swift # Classes/Player/PlayerWrapper/AVPlayerWrapper.swift
x-NR-x
added a commit
that referenced
this pull request
Apr 3, 2019
* stg/3.9.0: Set to release mode Updated version to 3.9.0 (#341) FEM-2475 Additional fix for the logic, removed the ':', otherwise the captions aren't selected. (#340) FEM-2475 - Fixed audio track crash, the mediaType returned from the option of audible tracks has changed. (#339) FEM-2466 Swift 4.2 (#338) Expose Creative ID and Advertiser Name (#330) FEM-2464 Expose player volume (#336) FEM-2463 There is no off state for audio tracks, it should default to auto. (#335) FEM-2393 Cap seek target (#333) FEM-2451 Player doesn't start playing once ready (#332) FEM-2387 Updated KalturaNetKit min version to 1.0.0. (#326) # Conflicts: # PlayKit.podspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
This is an enhancement to pass both the Creative ID and AdvertiserName from the Google Interactive Media Ads SDK through to PlayKit. There is a corresponding PR for the PlayKit IMA library that adds a similar change to the IMAExtensions.swift file allowing PKAdInfo to be constructed from a Google IMAAd object.
CheckLists
[*] changes have been done against master branch, and PR does not conflict
[*] new unit / functional tests have been added (whenever applicable)
None needed in my opinion.
[*] test are passing in local environment
No tests added for this.
[*] Travis tests are passing (or test results are not worse than on master branch :))
[*] Docs have been updated
There isn't much to do here since this is simply updating a property