Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEM-2451 Player doesn't start playing once ready #332

Merged
merged 2 commits into from
Mar 18, 2019
Merged

FEM-2451 Player doesn't start playing once ready #332

merged 2 commits into from
Mar 18, 2019

Conversation

x-NR-x
Copy link
Collaborator

@x-NR-x x-NR-x commented Mar 14, 2019

Description of the Changes

Reverting back, so that calling play will start the player once it is ready.

@x-NR-x x-NR-x self-assigned this Mar 14, 2019
@x-NR-x x-NR-x requested a review from noamtamim March 14, 2019 13:59
@x-NR-x x-NR-x merged commit 6112849 into develop Mar 18, 2019
@x-NR-x x-NR-x deleted the FEM-2451 branch March 18, 2019 13:36
x-NR-x added a commit that referenced this pull request Apr 2, 2019
* develop:
  FEM-2475 - Fixed audio track crash, the mediaType returned from the option of audible tracks has changed. (#339)
  FEM-2466 Swift 4.2 (#338)
  Expose Creative ID and Advertiser Name (#330)
  FEM-2464 Expose player volume (#336)
  FEM-2463 There is no off state for audio tracks, it should default to auto. (#335)
  FEM-2393 Cap seek target (#333)
  FEM-2451 Player doesn't start playing once ready (#332)

# Conflicts:
#	Classes/Player/PlayerController.swift
#	Classes/Player/PlayerWrapper/AVPlayerWrapper.swift
x-NR-x added a commit that referenced this pull request Apr 3, 2019
* stg/3.9.0:
  Set to release mode
  Updated version to 3.9.0 (#341)
  FEM-2475 Additional fix for the logic, removed the ':', otherwise the captions aren't selected. (#340)
  FEM-2475 - Fixed audio track crash, the mediaType returned from the option of audible tracks has changed. (#339)
  FEM-2466 Swift 4.2 (#338)
  Expose Creative ID and Advertiser Name (#330)
  FEM-2464 Expose player volume (#336)
  FEM-2463 There is no off state for audio tracks, it should default to auto. (#335)
  FEM-2393 Cap seek target (#333)
  FEM-2451 Player doesn't start playing once ready (#332)
  FEM-2387 Updated KalturaNetKit min version to 1.0.0. (#326)

# Conflicts:
#	PlayKit.podspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants