fix(FEC-14000): Download plugins opens empty overlay while there are … #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no files to download
added 2 commits
June 23, 2024 12:32
SivanA-Kaltura
requested changes
Jun 23, 2024
| @@ -34,7 +34,13 @@ module.exports = { | |||
| { | |||
| test: /\.scss$/, | |||
| use: [ | |||
| 'style-loader', | |||
| { | |||
There was a problem hiding this comment.
why is this needed ?
src/download.tsx
Outdated
| @@ -143,11 +144,11 @@ class Download extends KalturaPlayer.core.BasePlugin { | |||
| await this.ready; | |||
|
|
|||
| this.downloadPluginManager.setShowOverlay(false, false); | |||
| const downloadMetadata = await this.downloadPluginManager.getDownloadMetadata(true); | |||
| this.downloadMetadata = await this.downloadPluginManager.getDownloadMetadata(true); | |||
There was a problem hiding this comment.
we should also clean up the value, probably in reset()
SivanA-Kaltura
requested changes
Jun 23, 2024
| return flavor.height > 0; | ||
| }); | ||
| const sortedFlavors = flavors.sort((a: {height: number}, b: {height: number}) => { | ||
| return a.height < b.height ? 1 : -1; |
There was a problem hiding this comment.
Suggested change
| return a.height < b.height ? 1 : -1; | |
| return a.height - b.height; |
There was a problem hiding this comment.
you mean b - a in that case
There was a problem hiding this comment.
you're right
so b.height - a.height it is
This was referenced Jun 26, 2024
added 3 commits
July 14, 2024 21:05
SivanA-Kaltura
requested changes
Jul 15, 2024
| return flavor.height > 0; | ||
| }); | ||
| const sortedFlavors = flavors.sort((a: {height: number}, b: {height: number}) => { | ||
| return a.height < b.height ? 1 : -1; |
There was a problem hiding this comment.
you're right
so b.height - a.height it is
| @@ -158,7 +165,10 @@ class Download extends KalturaPlayer.core.BasePlugin { | |||
|
|
|||
| reset() { | |||
| this.upperBarManager?.remove(this.iconId); | |||
| // @ts-ignore | |||
| this.player.getService('AudioPluginsManager').remove(this.audioPlayerIconId) | |||
There was a problem hiding this comment.
you can add a getter for the service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves FEC-14000, FEC-13915 FEC-13939
Related pr:
kaltura/kaltura-player-js#805
kaltura/playkit-js-audio-player#27
kaltura/playkit-js-share#50
kaltura/playkit-js-transcript#205