fix(FEC-14000): Decoupling Plugins from Audio Player #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2024
JonathanTGold
commented
Jun 27, 2024
src/transcript-plugin.tsx
Outdated
| @@ -393,14 +399,18 @@ export class TranscriptPlugin extends KalturaPlayer.core.BasePlugin { | |||
| this._pluginState = PluginStates.CLOSED; | |||
| }; | |||
|
|
|||
| public isPluginAvailable = () => { | |||
| public isEntrySupported(): boolean { | |||
There was a problem hiding this comment.
I think isPluginAvailableForEntry is better descriptive name
SivanA-Kaltura
requested changes
Jul 15, 2024
| @@ -410,8 +419,11 @@ export class TranscriptPlugin extends KalturaPlayer.core.BasePlugin { | |||
| if (Math.max(this._transcriptPanel, this._transcriptIcon) > 0) { | |||
| this.sidePanelsManager?.remove(this._transcriptPanel); | |||
| this.upperBarManager!.remove(this._transcriptIcon); | |||
| // @ts-ignore | |||
| this.player.getService('AudioPluginsManager').remove(this._audioPlayerIconId); | |||
There was a problem hiding this comment.
you can add a getter function for the service
| @@ -271,11 +278,10 @@ export class TranscriptPlugin extends KalturaPlayer.core.BasePlugin { | |||
| }; | |||
|
|
|||
| private _addTranscriptItem(): void { | |||
| if (Math.max(this._transcriptPanel, this._transcriptIcon) > 0) { | |||
| if (Math.max(this._transcriptPanel, this._transcriptIcon, this._audioPlayerIconId) > 0) { | |||
There was a problem hiding this comment.
why is this needed ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoupling Plugins from Audio Player
Related pr:
kaltura/kaltura-player-js#805
kaltura/playkit-js-audio-player#27
kaltura/playkit-js-downloads#56
kaltura/playkit-js-share#50