the exit 0 at the end of the script means we will always exit with 0 #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which means the return 1 statements are useless.
currently, it will return 1 in line 80 echo "Service batch isn't running but stale lock file exists" echo "Removing stale lock file at $LOCKFILE" rm -f $LOCKFILE start_scheduler return 1 Regardless of the actual result.
customary to reflect the status in the output. good for say, getting it by mail, or when running from CLI or when you are color blind looking at the Nagios I/F :)
never use short tags.
reported by Martin Schygulla from SAP. never use short tags.
|
reverting changes and will open a pull per fix in separate branches. sigh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which means the return 1 statements are useless.