throw error if bundleConfig does not exist #6578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
approved these changes
Dec 24, 2017
yossipapi
reviewed
Dec 25, 2017
| @@ -428,6 +426,9 @@ private function initMembers() | |||
|
|
|||
| $this->bundleConfig = json_decode($confVars, true); | |||
| $this->mergeVersionsParamIntoConfig(); | |||
| if (!$this->bundleConfig) { | |||
There was a problem hiding this comment.
mergeVersionsParamIntoConfig uses the bundle config ($this->bundleConfig = array_merge($this->bundleConfig, $versionsArr);) so you may want to move this check up.
If bundleConfig in null and you will call array_merge it will result in a warning.
Another option is to define the bundleConfig to default value of an empty array and change this check accordingly.
| $isLatestVersionRequired = array_search("{latest}", $this->bundleConfig) !== false; | ||
| $isBetaVersionRequired = array_search("{beta}", $this->bundleConfig) !== false; | ||
| //if latest/beta version required set version number in config obj | ||
| $isLatestVersionRequired = array_search("{latest}", $this->bundleConfig) !== false; |
There was a problem hiding this comment.
Move the strings "{latest}" and "{beta}" to be class constants since you use them more than once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEC-7654